extensions/browser/guest_view/guest_view_base.cc - Issue 646983008: Implement signin using webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 646983008: Implement signin using webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash due to dangling zoom observer Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/guest_view_base.cc

diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc

index 2fbbf603020c336a136e2271ac121090f84d6d1e..0ec0d61878d1d404f88dceea9346cb4d8c1f8bbb 100644

--- a/extensions/browser/guest_view/guest_view_base.cc

+++ b/extensions/browser/guest_view/guest_view_base.cc

@@ -75,6 +75,10 @@ class GuestViewBase::EmbedderLifetimeObserver : public WebContentsObserver {

void AboutToNavigateRenderView(

content::RenderViewHost* render_view_host) override {

+ if (destroyed_)

+ return;

+ guest_->WillDetachFromEmbedder();

// If the embedder navigates then destroy the guest.

Destroy();

}