chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h - Issue 646983008: Implement signin using webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

Issue 646983008: Implement signin using webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash due to dangling zoom observer Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

index 9b9dca5949606e71fa3b3b98858e69a6db89aff7..4ce813d59699727611d7021d9fd2a537b14be106 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

@@ -37,6 +37,7 @@ class ChromeWebViewGuestDelegate : public extensions::WebViewGuestDelegate,

void OnDocumentLoadedInFrame(

content::RenderFrameHost* render_frame_host) override;

void OnGuestReady() override;

+ void OnWillDetachFromEmbedder() override;

void OnGuestDestroyed() override;

void OnSetZoom(double zoom_factor) override;

void OnShowContextMenu(int request_id, const MenuItemVector* items) override;