extensions/browser/api/web_request/web_request_api_helpers.cc - Issue 646983008: Implement signin using webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api_helpers.cc

Issue 646983008: Implement signin using webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_request/web_request_api_helpers.cc

diff --git a/extensions/browser/api/web_request/web_request_api_helpers.cc b/extensions/browser/api/web_request/web_request_api_helpers.cc

index 680a9532eef0864765dc3e0efae169d5a5aa9446..f96e8ec0fc76fd8d332f82d0ccbbcf6b7a4da0ba 100644

--- a/extensions/browser/api/web_request/web_request_api_helpers.cc

+++ b/extensions/browser/api/web_request/web_request_api_helpers.cc

@@ -1206,9 +1206,11 @@ void NotifyWebRequestAPIUsed(

extensions::RuntimeData* runtime_data =

extensions::ExtensionSystem::Get(browser_context)->runtime_data();

- if (runtime_data->HasUsedWebRequest(extension.get()))

- return;

- runtime_data->SetHasUsedWebRequest(extension.get(), true);

+ if (extension) {

+ if (runtime_data->HasUsedWebRequest(extension.get()))

+ return;

+ runtime_data->SetHasUsedWebRequest(extension.get(), true);

Fady Samuel 2014/10/21 21:32:57 What's going on here? I'm confused.

guohui 2014/10/22 15:35:33 lets continue discussion in the other cl https://c

+ }

for (content::RenderProcessHost::iterator it =

content::RenderProcessHost::AllHostsIterator();