components/signin/core/common/profile_management_switches.cc - Issue 646983008: Implement signin using webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/common/profile_management_switches.cc

Issue 646983008: Implement signin using webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed nits and updated histogram Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/common/profile_management_switches.cc

diff --git a/components/signin/core/common/profile_management_switches.cc b/components/signin/core/common/profile_management_switches.cc

index 2785cf4e8e7cd31e79486e43e41421c46fe1954e..f1a72033047ef77805873b79354742d2eb954671 100644

--- a/components/signin/core/common/profile_management_switches.cc

+++ b/components/signin/core/common/profile_management_switches.cc

@@ -126,7 +126,13 @@ bool IsEnableAccountConsistency() {

bool IsEnableWebBasedSignin() {

return CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kEnableWebBasedSignin) && !IsNewProfileManagement();

+ switches::kEnableWebBasedSignin) && !IsNewProfileManagement() &&

+ !IsEnableWebviewBasedSignin();

+bool IsEnableWebviewBasedSignin() {

+ return CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kEnableWebviewBasedSignin);

}

bool IsExtensionsMultiAccount() {