components/signin/core/browser/about_signin_internals.cc - Issue 646983008: Implement signin using webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/about_signin_internals.cc

Issue 646983008: Implement signin using webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed nits and updated histogram Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/about_signin_internals.cc

diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc

index 74b664ce38a4032dd7c11cd92af783c79aca7ee7..982e0e23dc683d09181e724dc213ddf6b2a47713 100644

--- a/components/signin/core/browser/about_signin_internals.cc

+++ b/components/signin/core/browser/about_signin_internals.cc

@@ -443,6 +443,8 @@ scoped_ptr<base::DictionaryValue> AboutSigninInternals::SigninStatus::ToValue(

AddSectionEntry(basic_info, "Signin Status", signin_status_string);

AddSectionEntry(basic_info, "Web Based Signin Enabled?",

switches::IsEnableWebBasedSignin() == true ? "True" : "False");

+ AddSectionEntry(basic_info, "Webview Based Signin Enabled?",

+ switches::IsEnableWebviewBasedSignin() == true ? "True" : "False");

AddSectionEntry(basic_info, "New Avatar Menu Enabled?",

switches::IsNewAvatarMenu() == true ? "True" : "False");

AddSectionEntry(basic_info, "New Profile Management Enabled?",