Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 646933002: Update .gitignore with test/test262-es6/data. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Update .gitignore with test/test262-es6/data. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24515

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-10 08:08:34 UTC) #1
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/646933002/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/646933002/diff/1/.gitignore#newcode62 .gitignore:62: /test/test262/data.old While you're at it, it ...
6 years, 2 months ago (2014-10-10 08:31:34 UTC) #2
Yang
6 years, 2 months ago (2014-10-10 08:48:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as 24515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698