MIPS: Fix loading Float64 constants in turbofan.

src/compiler/mips/code-generator-mips.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/gap-resolver.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/node-properties-inl.h"
 #include "src/mips/macro-assembler-mips.h"
@@ skipping 813 matching lines @@
       __ li(at, Operand(bit_cast<int32_t>(src.ToFloat32())));
       __ mtc1(at, dst);
       if (destination->IsDoubleStackSlot()) {
         __ swc1(dst, g.ToMemOperand(destination));
       }
     } else {
       DCHECK_EQ(Constant::kFloat64, src.type());
       DoubleRegister dst = destination->IsDoubleRegister()
                                ? g.ToDoubleRegister(destination)
                                : kScratchDoubleReg;
-      __ Move(dst, src.ToFloat64());
+      __ Move(dst, src.ToFloat64(), true);

[paul.l..., 2014/10/10 15:34:14]

nit: the bool at the call site here is a bit confusing to the reader, you might
consider making an enum value for this to enhance readability. Though naming of
this "force_load" functionality is not going to be very meaningful in this
context any way, so this can be optional. Let's have a brief side discussion
about this.

       if (destination->IsDoubleStackSlot()) {
         __ sdc1(dst, g.ToMemOperand(destination));
       }
     }
   } else if (source->IsDoubleRegister()) {
     FPURegister src = g.ToDoubleRegister(source);
     if (destination->IsDoubleRegister()) {
       FPURegister dst = g.ToDoubleRegister(destination);
       __ Move(dst, src);
     } else {
@@ skipping 109 matching lines @@
     }
   }
   MarkLazyDeoptSite();
 }
 
 #undef __
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8