MIPS: Fix loading Float64 constants in turbofan.

MIPS: Fix loading Float64 constants in turbofan.

TEST=ctest/test-run-machops/RunFloat64SubImm1,
     RunFloat64SubImm2, RunFloat64MulImm, RunFloat64Compare

BUG=
R=paul.lind@imgtec.com

Committed: https://code.google.com/p/v8/source/detail?r=24536

[dusmil.imgtec, 2014-10-10 13:04:24]

dusan.milosavljevic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com, danno@chromium.org,
paul.lind@imgtec.com, titzer@chromium.org

[paul.l..., 2014-10-10 15:34:15]

LGTM, nice catch on the uninitialized kDoubleRegZero in the cctests.

https://codereview.chromium.org/646923003/diff/1/src/compiler/mips/code-gener...
File src/compiler/mips/code-generator-mips.cc (right):

https://codereview.chromium.org/646923003/diff/1/src/compiler/mips/code-gener...
src/compiler/mips/code-generator-mips.cc:834: __ Move(dst, src.ToFloat64(),
true);
nit: the bool at the call site here is a bit confusing to the reader, you might
consider making an enum value for this to enhance readability. Though naming of
this "force_load" functionality is not going to be very meaningful in this
context any way, so this can be optional. Let's have a brief side discussion
about this.

[paul.l..., 2014-10-10 17:35:20]

LGTM, once you fix the naming convention issue.

https://codereview.chromium.org/646923003/diff/100001/src/mips/macro-assemble...
File src/mips/macro-assembler-mips.h (right):

https://codereview.chromium.org/646923003/diff/100001/src/mips/macro-assemble...
src/mips/macro-assembler-mips.h:1668: bool has_double_zero_reg_set;
You need a trailing underscore on this var: has_double_zero_reg_set_;

[dusmil.imgtec, 2014-10-10 17:43:47]

On 2014/10/10 17:35:20, paul.l... wrote:
> LGTM, once you fix the naming convention issue.
> 
>
https://codereview.chromium.org/646923003/diff/100001/src/mips/macro-assemble...
> File src/mips/macro-assembler-mips.h (right):
> 
>
https://codereview.chromium.org/646923003/diff/100001/src/mips/macro-assemble...
> src/mips/macro-assembler-mips.h:1668: bool has_double_zero_reg_set;
> You need a trailing underscore on this var: has_double_zero_reg_set_;

Right, I'll fix this and land it.

[dusmil.imgtec, 2014-10-10 18:01:09]

Committed patchset #3 (id:150001) manually as 24536 (presubmit successful).