Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 646913002: Force synchronized parser for substitute main resource load marked forceSynchronousLoad. (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Project:
blink
Visibility:
Public.

Description

Force synchronized parser for substitute main resource load marked forceSynchronousLoad. Before this CL, synchronized parsing for forceSynchronousLoad substituteData was not enforced. The flag was simply ignored in parsing code path. This bug has not surfaced because all substituteData which required synchronized loading were used against about:blank URL, and HTMLDocumentParserOptions had a special casing that about:blank urls required synchronous parsing. This CL explicitly enforces synchronous parse for forceSynchronousLoad substituteData, so that flag is actually used. This is also a step toward removing special casing against about:black URL in HTMLDocumentParser. BUG=421289 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M Source/core/loader/DocumentLoader.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/loader/DocumentWriter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
kouhei (in TOK)
6 years, 2 months ago (2014-10-10 05:23:51 UTC) #2
kouhei (in TOK)
This is to address test failures on https://codereview.chromium.org/644573002/ , which removed special casing for about:blank ...
6 years, 2 months ago (2014-10-10 05:25:20 UTC) #3
kouhei (in TOK)
6 years, 2 months ago (2014-10-10 07:07:32 UTC) #5
Nate Chapin
lgtm
6 years, 2 months ago (2014-10-10 23:41:48 UTC) #6
kouhei (in TOK)
Thanks for review!
6 years, 2 months ago (2014-10-11 03:04:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646913002/1
6 years, 2 months ago (2014-10-11 03:05:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 03:29:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183570

Powered by Google App Engine
This is Rietveld 408576698