Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 6469032: Update the NOTICE file to include *all* the 3rd party licence notices (boost,... (Closed)

Created:
9 years, 10 months ago by David Springer
Modified:
9 years, 7 months ago
Reviewers:
cstefansen, Matt Ball
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update the NOTICE file to include *all* the 3rd party licence notices (boost, gtest, gmock). BUG=http://code.google.com/p/nativeclient/issues/detail?id=1408 TEST=Download SDK, inspect the NOTICE file and make sure it references boost, gtest and gmock. Committed: http://code.google.com/p/nativeclient-sdk/source/detail?r=720 Committed: http://code.google.com/p/nativeclient-sdk/source/detail?r=721

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge CL 6469032 into the AcrticSea branch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -0 lines) Patch
M NOTICE View 1 1 chunk +286 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
David Springer
Note that we will want to roll this into the ArcticSea branch...
9 years, 10 months ago (2011-02-10 16:45:37 UTC) #1
Matt Ball
LGTM with one comment. I'm assuming that we'll also want to merge this up to ...
9 years, 10 months ago (2011-02-10 16:50:35 UTC) #2
David Springer
Yes, we want to pull this into the branch... http://codereview.chromium.org/6469032/diff/1/NOTICE File NOTICE (right): http://codereview.chromium.org/6469032/diff/1/NOTICE#newcode7 NOTICE:7: ...
9 years, 10 months ago (2011-02-10 17:42:20 UTC) #3
Matt Ball
On 2011/02/10 17:42:20, David Springer wrote: > Yes, we want to pull this into the ...
9 years, 10 months ago (2011-02-10 17:43:59 UTC) #4
David Springer
Thanks for the reviews! Committed as rev 720. CL to roll into the branch pending.
9 years, 10 months ago (2011-02-10 18:00:46 UTC) #5
David Springer
9 years, 10 months ago (2011-02-10 19:29:57 UTC) #6
r721 merged into ArcticSea, pushed to the mirror.

Powered by Google App Engine
This is Rietveld 408576698