Issue 6469005: make generator: refactor shared headers together...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6469005: make generator: refactor shared headers together... (Closed)

Created:
9 years, 10 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Michael Moss

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Description

make generator: refactor shared headers together There's no need to concatenate a bunch of strings and replace a magic __underscored__ name; Python has a built-in templating language. Committed: http://code.google.com/p/gyp/source/detail?r=883

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -20 lines)			Patch
	M	pylib/gyp/generator/make.py	View		6 chunks	+14 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

and it's time to read a python book again.

Expand Messages | Collapse Messages