Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 646863004: Update the manifests for IME extensions. (Closed)

Created:
6 years, 2 months ago by Shu Chen
Modified:
6 years, 2 months ago
Reviewers:
James Su
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update the manifests for IME extensions. 1) Avoid using 'us' as password layout for those layouts can be remapped to 'us'. 2) Norwegian decoding language should be 'no', and password layout should not be no.compact.qwerty instead of us.compact.qwerty. 3) Korean 2set IME can use m17n:ko_2set layout. 4) Korean IMEs OSK url uses hash to support fast switching. BUG=416504 TEST=Verified on linux_chromeos. Committed: https://crrev.com/cd24a4834073778a53c4d519c6060818c6297f7b Cr-Commit-Position: refs/heads/master@{#299070}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M chrome/browser/resources/chromeos/input_method/google_input_tools_manifest.json View 28 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/input_method/hangul_manifest.json View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/xkb_manifest.json View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 11 (2 generated)
Shu Chen
suzhe@, can you please review this cl? Thanks!
6 years, 2 months ago (2014-10-10 04:49:45 UTC) #2
James Su
https://codereview.chromium.org/646863004/diff/1/chrome/browser/resources/chromeos/input_method/xkb_manifest.json File chrome/browser/resources/chromeos/input_method/xkb_manifest.json (right): https://codereview.chromium.org/646863004/diff/1/chrome/browser/resources/chromeos/input_method/xkb_manifest.json#newcode443 chrome/browser/resources/chromeos/input_method/xkb_manifest.json:443: "input_view": "inputview.html?id=no.compact.qwerty&language=no&passwordLayout=no.compact.qwerty&name=keyboard_norwegian" other files use # instead ?, which ...
6 years, 2 months ago (2014-10-10 05:29:50 UTC) #3
Shu Chen
https://codereview.chromium.org/646863004/diff/1/chrome/browser/resources/chromeos/input_method/xkb_manifest.json File chrome/browser/resources/chromeos/input_method/xkb_manifest.json (right): https://codereview.chromium.org/646863004/diff/1/chrome/browser/resources/chromeos/input_method/xkb_manifest.json#newcode443 chrome/browser/resources/chromeos/input_method/xkb_manifest.json:443: "input_view": "inputview.html?id=no.compact.qwerty&language=no&passwordLayout=no.compact.qwerty&name=keyboard_norwegian" On 2014/10/10 05:29:50, James Su wrote: > ...
6 years, 2 months ago (2014-10-10 05:42:30 UTC) #4
James Su
On 2014/10/10 05:42:30, Shu Chen wrote: > https://codereview.chromium.org/646863004/diff/1/chrome/browser/resources/chromeos/input_method/xkb_manifest.json > File chrome/browser/resources/chromeos/input_method/xkb_manifest.json (right): > > https://codereview.chromium.org/646863004/diff/1/chrome/browser/resources/chromeos/input_method/xkb_manifest.json#newcode443 ...
6 years, 2 months ago (2014-10-10 05:54:20 UTC) #5
James Su
On 2014/10/10 05:54:20, James Su wrote: > On 2014/10/10 05:42:30, Shu Chen wrote: > > ...
6 years, 2 months ago (2014-10-10 05:55:53 UTC) #6
Shu Chen
On 2014/10/10 05:54:20, James Su wrote: > On 2014/10/10 05:42:30, Shu Chen wrote: > > ...
6 years, 2 months ago (2014-10-10 05:57:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646863004/1
6 years, 2 months ago (2014-10-10 06:08:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 06:56:22 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 06:57:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd24a4834073778a53c4d519c6060818c6297f7b
Cr-Commit-Position: refs/heads/master@{#299070}

Powered by Google App Engine
This is Rietveld 408576698