Issue 646853007: Remove fallback matching ::cue* pseudo-element selectors

Issue 646853007: Remove fallback matching ::cue* pseudo-element selectors (Closed)

Created:
6 years, 2 months ago by philipj_slow

Modified:
6 years, 2 months ago

Reviewers:
rune

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Remove fallback matching ::cue* pseudo-element selectors Because there is a "cue" entry in both pseudoTypeWithoutArgumentsMap and pseudoTypeWithArgumentsMap, this path is never taken (verified with ASSERT(0)) when running LayoutTests/media/. It is taken for something like ::cuefoo, but that makes no sense. This was initially the only code path: http://trac.webkit.org/changeset/136991 Later commits made it obsolete: http://trac.webkit.org/changeset/137955 https://src.chromium.org/viewvc/blink?revision=155834&view=revision This was the last usage of PseudoUserAgentCustomElement, so remove that too, together with its use counter: https://src.chromium.org/viewvc/blink?revision=155928&view=revision https://www.chromestatus.com/metrics/feature/timeline/popularity/103 At the time pseudos starting with "x-" were also PseudoUserAgentCustomElement, but has since been removed: https://src.chromium.org/viewvc/blink?revision=170210&view=revision Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184341

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
M	Source/core/css/CSSSelector.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/css/CSSSelector.cpp	View	1	3 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/css/RuleFeature.cpp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/parser/BisonCSSParser-in.cpp	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorTraceEvents.cpp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 10 (2 generated)

rune

On 2014/10/24 08:29:39, rune wrote: > Great! LGTM Once you've fixed the inspector dependencies.

6 years, 2 months ago (2014-10-24 08:33:42 UTC) #5

philipj_slow

On 2014/10/24 08:33:42, rune wrote: > On 2014/10/24 08:29:39, rune wrote: > > Great! LGTM ...

6 years, 2 months ago (2014-10-24 08:46:05 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646853007/40001

6 years, 2 months ago (2014-10-24 08:50:59 UTC) #9

commit-bot: I haz the power

6 years, 2 months ago (2014-10-24 09:47:00 UTC) #10

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 184341