Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/ui/webui/options/options_browsertest.js

Issue 646853004: Enable a11y audit for chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/options_browsertest.js b/chrome/browser/ui/webui/options/options_browsertest.js
index a8c6b5898cef1ac1a894fc1a54c5504ba063df71..367730ab35110d25e4f34095ea42c9776cc1e88a 100644
--- a/chrome/browser/ui/webui/options/options_browsertest.js
+++ b/chrome/browser/ui/webui/options/options_browsertest.js
@@ -46,6 +46,9 @@ OptionsWebUITest.prototype = {
__proto__: testing.Test.prototype,
/** @override */
+ runAccessibilityChecks: true,
+
+ /** @override */
accessibilityIssuesAreErrors: true,
/** @override */
@@ -380,6 +383,12 @@ OptionsWebUIExtendedTest.prototype = {
isAsync: true,
/** @override */
+ runAccessibilityChecks: true,
+
+ /** @override */
+ accessibilityIssuesAreErrors: true,
+
+ /** @override */
setUp: function() {
// user-image-stream is a streaming video element used for capturing a
// user image during OOBE.
@@ -708,7 +717,17 @@ TEST_F('OptionsWebUIExtendedTest', 'CloseOverlayWithHashes', function() {
this.verifyHistory_(
['', 'search#1', 'languages#2', 'addLanguage#3', 'languages#2',
'search#1'],
- testDone);
+ function() {
Dan Beam 2014/10/21 23:13:56 function() { document.addEventListener('webkitTr
hcarmona 2014/10/22 17:36:20 Done.
+ var done = false;
+ document.addEventListener(
+ 'webkitTransitionEnd',
+ function finishTest(e) {
+ if (!done) {
+ done = true;
+ testDone();
+ }
+ });
+ });
}.bind(this));
}.bind(this));
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698