Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
646853002:
Link to skiadocs site, since that is the canonical location for documentation. (Closed)
DescriptionLink to skiadocs site, since that is the canonical location for documentation.
BUG=None
TEST=None
R=borenet@google.com, rmistry@google.com
Committed: https://skia.googlesource.com/skia/+/be23418776414ccc6d534ba4dcbe1361b94f4356
Patch Set 1 #Messages
Total messages: 17 (7 generated)
tfarina@chromium.org changed reviewers: + borenet@google.com - rmistry@google.com
Redirecting this to Eric, since Ravi is OOO today.
LGTM
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for make.bat: While running git apply --index -3 -p1; error: patch failed: make.bat:5 Falling back to three-way merge... error: patch failed: make.bat:5 error: make.bat: patch does not apply Patch: make.bat Index: make.bat diff --git a/make.bat b/make.bat index 2b6a629ff377d6554faa277df924e328135e7866..94d0755912a10682cb9146331ca3482952d5a6f1 100644 --- a/make.bat +++ b/make.bat @@ -5,7 +5,7 @@ @ECHO OFF rem Launches make.py on Windows, after setting Visual Studio environment variables. -rem See http://code.google.com/p/skia/wiki/GettingStartedOnWindows +rem See https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides/... rem Skip environment setup on bots. if "%CHROME_HEADLESS%"=="1" goto run_python
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for make.bat: While running git apply --index -3 -p1; error: patch failed: make.bat:5 Falling back to three-way merge... error: patch failed: make.bat:5 error: make.bat: patch does not apply Patch: make.bat Index: make.bat diff --git a/make.bat b/make.bat index 2b6a629ff377d6554faa277df924e328135e7866..94d0755912a10682cb9146331ca3482952d5a6f1 100644 --- a/make.bat +++ b/make.bat @@ -5,7 +5,7 @@ @ECHO OFF rem Launches make.py on Windows, after setting Visual Studio environment variables. -rem See http://code.google.com/p/skia/wiki/GettingStartedOnWindows +rem See https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides/... rem Skip environment setup on bots. if "%CHROME_HEADLESS%"=="1" goto run_python
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for make.bat: While running git apply --index -3 -p1; error: patch failed: make.bat:5 Falling back to three-way merge... error: patch failed: make.bat:5 error: make.bat: patch does not apply Patch: make.bat Index: make.bat diff --git a/make.bat b/make.bat index 2b6a629ff377d6554faa277df924e328135e7866..94d0755912a10682cb9146331ca3482952d5a6f1 100644 --- a/make.bat +++ b/make.bat @@ -5,7 +5,7 @@ @ECHO OFF rem Launches make.py on Windows, after setting Visual Studio environment variables. -rem See http://code.google.com/p/skia/wiki/GettingStartedOnWindows +rem See https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides/... rem Skip environment setup on bots. if "%CHROME_HEADLESS%"=="1" goto run_python
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as be23418776414ccc6d534ba4dcbe1361b94f4356 (presubmit successful). |
