Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 646843002: Fix reference to non-existant 'tests' target. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix reference to non-existant 'tests' target. This target was previously folded into dm. Do not advertise it anymore. BUG=None TEST=None R=borenet@google.com Committed: https://skia.googlesource.com/skia/+/e6402ca6eebffa972876de121a72160066d16efe

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M make.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
tfarina
6 years, 2 months ago (2014-10-10 03:54:31 UTC) #1
tfarina
Eric, could you approve this?
6 years, 2 months ago (2014-10-13 14:16:48 UTC) #3
borenet
LGTM
6 years, 2 months ago (2014-10-13 14:19:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646843002/1
6 years, 2 months ago (2014-10-13 14:22:37 UTC) #6
commit-bot: I haz the power
Failed to apply patch for make.py: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-13 14:22:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646843002/100001
6 years, 2 months ago (2014-10-13 20:49:12 UTC) #10
commit-bot: I haz the power
Failed to apply patch for make.py: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-13 20:49:15 UTC) #12
tfarina
6 years, 2 months ago (2014-10-13 20:52:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:100001) manually as
e6402ca6eebffa972876de121a72160066d16efe.

Powered by Google App Engine
This is Rietveld 408576698