Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: Source/platform/heap/ThreadState.h

Issue 646833003: Oilpan: Mark the NodeList hierarchy MainThreadOnly (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/ThreadState.h
diff --git a/Source/platform/heap/ThreadState.h b/Source/platform/heap/ThreadState.h
index 54e561338f10ccdbeae0478031f2e27c7411f688..9d2dd61018721f303bdd0dfe323ccaa70da73910 100644
--- a/Source/platform/heap/ThreadState.h
+++ b/Source/platform/heap/ThreadState.h
@@ -84,10 +84,15 @@ enum ThreadAffinity {
MainThreadOnly,
};
+// FIXME: These forward declarations violate dependency rules. Remove them.
+// Ideally we want to provide a USED_IN_MAIN_THREAD_ONLY(T) macro, which
+// indicates that classes in T's hierarchy are used only by the main thread.
haraken 2014/10/15 01:12:56 I'm planning to address the FIXME by introducing G
tkent 2014/10/15 03:34:39 The GarbageCollectedOnMainThread approach sounds g
class Node;
-class CSSValue;
+class NodeList;
-template<typename T, bool derivesNode = WTF::IsSubclass<typename WTF::RemoveConst<T>::Type, Node>::value> struct DefaultThreadingTrait;
+template<typename T,
+ bool derivesNode = WTF::IsSubclass<typename WTF::RemoveConst<T>::Type, Node>::value
tkent 2014/10/15 03:34:39 Now derivesNode is a wrong name. It will be remov
haraken 2014/10/15 03:38:59 Renamed it to mainThreadOnly.
+ || WTF::IsSubclass<typename WTF::RemoveConst<T>::Type, NodeList>::value> struct DefaultThreadingTrait;
template<typename T>
struct DefaultThreadingTrait<T, false> {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698