Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_service_client.cc

Issue 64683014: Mac OS X-specific implementation of Networking Private API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address codereview comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_service_client.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc b/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc
index 9d5e47e5a60668e3461c40eb8e594fa6ef126413..d9925cc52a74d23f982de09c6cf1bc09280e5794 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc
@@ -23,7 +23,6 @@ namespace extensions {
namespace {
-const char kNetworkingPrivateServiceClient[] = "NetworkingPrivateServiceClient";
const char kNetworkingPrivateSequenceTokenName[] = "NetworkingPrivate";
// Implementation of Verify* methods using NetworkingPrivateCrypto.
@@ -124,6 +123,7 @@ NetworkingPrivateServiceClient::NetworkingPrivateServiceClient(
&WiFiService::Initialize,
base::Unretained(wifi_service_.get()),
task_runner_));
+ net::NetworkChangeNotifier::AddNetworkChangeObserver(this);
}
NetworkingPrivateServiceClient::~NetworkingPrivateServiceClient() {
@@ -144,6 +144,7 @@ NetworkingPrivateServiceClient::ServiceCallbacks::~ServiceCallbacks() {}
void NetworkingPrivateServiceClient::Shutdown() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
// Clear callbacks map to release callbacks from UI thread.
callbacks_map_.Clear();
// Post ShutdownServicesOnWorkerThread task to delete services when all posted
@@ -163,6 +164,14 @@ void NetworkingPrivateServiceClient::RemoveObserver(Observer* observer) {
network_events_observers_.RemoveObserver(observer);
}
+void NetworkingPrivateServiceClient::OnNetworkChanged(
+ net::NetworkChangeNotifier::ConnectionType type) {
+ task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&WiFiService::RequestConnectedNetworkUpdate,
+ base::Unretained(wifi_service_.get())));
+}
+
NetworkingPrivateServiceClient::ServiceCallbacks*
NetworkingPrivateServiceClient::AddServiceCallbacks() {
ServiceCallbacks* service_callbacks = new ServiceCallbacks();

Powered by Google App Engine
This is Rietveld 408576698