Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/wifi/wifi_service.h

Issue 64683014: Mac OS X-specific implementation of Networking Private API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Explicitly track connected_network_guid and use it to notify network disconnect. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/wifi/wifi_service.h
diff --git a/components/wifi/wifi_service.h b/components/wifi/wifi_service.h
index b45ebfdeb1386feec4ac5d3a20824b74529a85ff..35c95b5800053742c02d23f4caed210ebfa5f55e 100644
--- a/components/wifi/wifi_service.h
+++ b/components/wifi/wifi_service.h
@@ -6,6 +6,7 @@
#define CHROME_UTILITY_WIFI_WIFI_SERVICE_H_
#include <list>
+#include <set>
#include <string>
#include <vector>
@@ -19,9 +20,11 @@
namespace wifi {
// WiFiService interface used by implementation of chrome.networkingPrivate
-// JavaScript extension API. All methods should be called on worker thread.
+// JavaScript extension API. All methods should be called on worker thread or.
+// posted to worker pool using SequencedTaskRunner |task_runner_|.
tbarzic 2014/01/27 20:17:24 You don't need the second part of the sentence. (e
mef 2014/01/27 23:08:27 Done.
// It could be created on any (including UI) thread, so nothing expensive should
-// be done in the constructor.
+// be done in the constructor. See |NetworkingPrivateService| for wrapper
+// accessible on UI thread.
class WIFI_EXPORT WiFiService {
public:
typedef std::vector<std::string> NetworkGuidList;
@@ -116,7 +119,7 @@ class WIFI_EXPORT WiFiService {
kFrequency5000 = 5000
};
- typedef std::list<Frequency> FrequencyList;
+ typedef std::set<Frequency> FrequencySet;
// Network Properties, used as result of |GetProperties| and
// |GetVisibleNetworks|.
struct WIFI_EXPORT NetworkProperties {
@@ -138,7 +141,7 @@ class WIFI_EXPORT WiFiService {
uint32 signal_strength;
bool auto_connect;
Frequency frequency;
- FrequencyList frequency_list;
+ FrequencySet frequency_set;
std::string json_extra; // Extra JSON properties for unit tests

Powered by Google App Engine
This is Rietveld 408576698