Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: Source/core/svg/properties/SVGAnimatedProperty.cpp

Issue 64683006: [svg] TearOffs dynamically hold on to the current contextElement(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: gchack Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
3 * Copyright (C) 2013 Samsung Electronics. All rights reserved. 3 * Copyright (C) 2013 Samsung Electronics. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 14 matching lines...) Expand all
25 25
26 namespace WebCore { 26 namespace WebCore {
27 27
28 SVGAnimatedProperty::SVGAnimatedProperty(SVGElement* contextElement, const Quali fiedName& attributeName, AnimatedPropertyType animatedPropertyType) 28 SVGAnimatedProperty::SVGAnimatedProperty(SVGElement* contextElement, const Quali fiedName& attributeName, AnimatedPropertyType animatedPropertyType)
29 : m_contextElement(contextElement) 29 : m_contextElement(contextElement)
30 , m_attributeName(attributeName) 30 , m_attributeName(attributeName)
31 , m_animatedPropertyType(animatedPropertyType) 31 , m_animatedPropertyType(animatedPropertyType)
32 , m_isAnimating(false) 32 , m_isAnimating(false)
33 , m_isReadOnly(false) 33 , m_isReadOnly(false)
34 { 34 {
35 contextElement->setContextElement();
haraken 2013/11/13 06:08:59 Isn't there any chance where we want to unset a co
35 } 36 }
36 37
37 SVGAnimatedProperty::~SVGAnimatedProperty() 38 SVGAnimatedProperty::~SVGAnimatedProperty()
38 { 39 {
39 // Assure that animationEnded() was called, if animationStarted() was called before. 40 // Assure that animationEnded() was called, if animationStarted() was called before.
40 ASSERT(!m_isAnimating); 41 ASSERT(!m_isAnimating);
41 } 42 }
42 43
43 void SVGAnimatedProperty::detachAnimatedPropertiesForElement(SVGElement* element ) 44 void SVGAnimatedProperty::detachAnimatedPropertiesForElement(SVGElement* element )
44 { 45 {
(...skipping 22 matching lines...) Expand all
67 m_contextElement->svgAttributeChanged(m_attributeName); 68 m_contextElement->svgAttributeChanged(m_attributeName);
68 } 69 }
69 70
70 SVGAnimatedProperty::Cache* SVGAnimatedProperty::animatedPropertyCache() 71 SVGAnimatedProperty::Cache* SVGAnimatedProperty::animatedPropertyCache()
71 { 72 {
72 static Cache* s_cache = new Cache; 73 static Cache* s_cache = new Cache;
73 return s_cache; 74 return s_cache;
74 } 75 }
75 76
76 } // namespace WebCore 77 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698