Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 646803005: Web MIDI: move static helper methods to functions in anonymous namespace (Closed)

Created:
6 years, 2 months ago by Takashi Toyoshima
Modified:
6 years, 2 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: move static helper methods to functions in anonymous namespace BUG=n/a TEST=n/a Committed: https://crrev.com/d5e96783cb8c3c6b1d77bb61d999f4323e648232 Cr-Commit-Position: refs/heads/master@{#299433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -61 lines) Patch
M media/midi/midi_manager_mac.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/midi/midi_manager_mac.cc View 2 chunks +57 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Takashi Toyoshima
PTAL. This is just a mechanical change to prepare coming CLs to support adding detected ...
6 years, 2 months ago (2014-10-10 13:04:54 UTC) #2
yhirano
lgtm. s/anonymous space/anonymous namespace/g
6 years, 2 months ago (2014-10-10 14:45:03 UTC) #3
Takashi Toyoshima
thanks. updated the description.
6 years, 2 months ago (2014-10-14 03:57:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646803005/1
6 years, 2 months ago (2014-10-14 03:58:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 05:56:27 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 06:17:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5e96783cb8c3c6b1d77bb61d999f4323e648232
Cr-Commit-Position: refs/heads/master@{#299433}

Powered by Google App Engine
This is Rietveld 408576698