Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 646803004: Squeeze the layout of various AST node types. (Closed)

Created:
6 years, 2 months ago by Sven Panne
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Squeeze the layout of various AST node types. The following AST node types were improved (in decreasing number of importance for asm.js-like source code): Expression, VariableProxy, Assignment, BinaryOperation, Declaration, Property, Call. BUG=chromium:417697 LOG=y R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24593

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -56 lines) Patch
M src/ast.h View 1 11 chunks +43 lines, -44 lines 0 comments Download
M src/ast.cc View 1 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 2 months ago (2014-10-10 12:42:55 UTC) #1
mvstanton
LGTM
6 years, 2 months ago (2014-10-10 12:58:29 UTC) #2
Sven Panne
6 years, 2 months ago (2014-10-14 10:24:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as 24593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698