Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: mojo/bindings/js/handle.h

Issue 646783005: Mojo JS Bindings: Mojo handles need a toString() method Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed address from output, added a unit test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/bindings/js/handle.cc » ('j') | mojo/public/js/bindings/core_unittests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/bindings/js/handle.h
diff --git a/mojo/bindings/js/handle.h b/mojo/bindings/js/handle.h
index b0f250c61a5f2c99477260cbc50fa493876e929e..f045ee3a52ea4fd77fdaf3d93d39c92fd288895d 100644
--- a/mojo/bindings/js/handle.h
+++ b/mojo/bindings/js/handle.h
@@ -8,6 +8,7 @@
#include "base/observer_list.h"
#include "gin/converter.h"
#include "gin/handle.h"
+#include "gin/object_template_builder.h"
#include "gin/wrappable.h"
#include "mojo/public/cpp/system/core.h"
@@ -26,6 +27,11 @@ class HandleWrapper : public gin::Wrappable<HandleWrapper> {
return gin::CreateHandle(isolate, new HandleWrapper(handle));
}
+ std::string ToString();
+
+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate)
+ override;
+
mojo::Handle get() const { return handle_.get(); }
mojo::Handle release() { return handle_.release(); }
void Close();
« no previous file with comments | « no previous file | mojo/bindings/js/handle.cc » ('j') | mojo/public/js/bindings/core_unittests.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698