Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 646773004: [iOS] Load chrome_300_percent.pak file on @3x devices. (Closed)

Created:
6 years, 2 months ago by lliabraa
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[iOS] Load chrome_300_percent.pak file on @3x devices. This CL adds support for loading assets from the chrome_300_percent.pak file on devices that support @3x scale. BUG=423762 Committed: https://crrev.com/f1f77bfa7af91abcab9b7f69f9d5c3d65d4c08e8 Cr-Commit-Position: refs/heads/master@{#301142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M ui/base/resource/resource_bundle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
lliabraa
6 years, 2 months ago (2014-10-15 19:38:03 UTC) #2
lliabraa
+tony for OWNERS
6 years, 2 months ago (2014-10-17 12:20:15 UTC) #4
tony
LGTM
6 years, 2 months ago (2014-10-17 16:54:24 UTC) #5
rohitrao (ping after 24h)
Do you think we should put this behind a flag? Or would we just revert ...
6 years, 2 months ago (2014-10-21 20:31:21 UTC) #6
lliabraa
On 2014/10/21 20:31:21, rohitrao wrote: > Do you think we should put this behind a ...
6 years, 2 months ago (2014-10-21 20:37:08 UTC) #7
rohitrao (ping after 24h)
lgtm
6 years, 2 months ago (2014-10-21 20:38:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646773004/1
6 years, 1 month ago (2014-10-24 16:59:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-24 17:53:40 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 17:54:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1f77bfa7af91abcab9b7f69f9d5c3d65d4c08e8
Cr-Commit-Position: refs/heads/master@{#301142}

Powered by Google App Engine
This is Rietveld 408576698