Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 646753003: Correctly set controlled-setting-indicators in internet_detail.html (Closed)

Created:
6 years, 2 months ago by stevenjb
Modified:
6 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correctly set controlled-setting-indicators in internet_detail.html BUG=425164 Committed: https://crrev.com/e3159f0995c1a21e0d97edce19ca3048b314a9cb Cr-Commit-Position: refs/heads/master@{#300372}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/browser/resources/options/chromeos/internet_detail.html View 1 10 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stevenjb
6 years, 2 months ago (2014-10-20 20:12:36 UTC) #2
pneubeck (no reviews)
lgtm, sorry that I didn't see that in the original review. Luckily we updated the ...
6 years, 2 months ago (2014-10-20 20:20:02 UTC) #3
stevenjb
https://codereview.chromium.org/646753003/diff/1/chrome/browser/resources/options/chromeos/internet_detail.html File chrome/browser/resources/options/chromeos/internet_detail.html (right): https://codereview.chromium.org/646753003/diff/1/chrome/browser/resources/options/chromeos/internet_detail.html#newcode500 chrome/browser/resources/options/chromeos/internet_detail.html:500: mabaged="Cellular.SIMLockStatus.LockEnabled"></span> On 2014/10/20 20:20:02, pneubeck wrote: > typo: mabaged ...
6 years, 2 months ago (2014-10-20 21:32:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646753003/20001
6 years, 2 months ago (2014-10-20 21:35:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 23:06:55 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 23:08:11 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e3159f0995c1a21e0d97edce19ca3048b314a9cb
Cr-Commit-Position: refs/heads/master@{#300372}

Powered by Google App Engine
This is Rietveld 408576698