chrome/common/safe_browsing/csd.proto - Issue 646733002: Added incident report for variations seed signature mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Responded to comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_handlers_unittest.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/csd.proto

diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto

index ca77f3b91ef5c8e59ede8c7f8a0751e7231c9ec0..ba6c68295c7a85c2ff835a8eee233a3609d74f6b 100644

--- a/chrome/common/safe_browsing/csd.proto

+++ b/chrome/common/safe_browsing/csd.proto

@@ -362,10 +362,14 @@ message ClientIncidentReport {

optional string version = 3;

optional bool blacklist_initialized = 4;

}

+ message VariationsSeedSignatureIncident {

+ optional string variations_seed_signature = 1;

Alexei Svitkine (slow) 2014/10/14 18:15:06 You should probably comment and mention that this

Georges Khalil 2014/10/15 14:41:47 Discussed with owners offline.

+ }

optional int64 incident_time_msec = 1;

optional TrackedPreferenceIncident tracked_preference = 2;

optional BinaryIntegrityIncident binary_integrity = 3;

optional BlacklistLoadIncident blacklist_load = 4;

+ optional VariationsSeedSignatureIncident variations_seed_signature = 5;

}

repeated IncidentData incident = 1;