Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Unified Diff: chrome/browser/metrics/variations/variations_seed_store.h

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Responded to comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_seed_store.h
diff --git a/chrome/browser/metrics/variations/variations_seed_store.h b/chrome/browser/metrics/variations/variations_seed_store.h
index c81b15e3e0967def607055df822dd13cd7ed7371..834bf2521dcabf070bfe02ef1d157b92fc7e1baf 100644
--- a/chrome/browser/metrics/variations/variations_seed_store.h
+++ b/chrome/browser/metrics/variations/variations_seed_store.h
@@ -55,6 +55,11 @@ class VariationsSeedStore {
// Registers Local State prefs used by this class.
static void RegisterPrefs(PrefRegistrySimple* registry);
+ // If the loaded signature is invalid, returns true and sets
+ // |invalid_signature| to the loaded signature. Otherwise returns false and
Alexei Svitkine (slow) 2014/10/14 18:15:06 I would mention that the content of |invalid_signa
Georges Khalil 2014/10/15 14:41:47 Done.
+ // |invalid_signature| is not modified.
+ bool GetInvalidSignature(std::string* invalid_signature) const;
+
protected:
// Note: UMA histogram enum - don't re-order or remove entries.
enum VerifySignatureResult {
@@ -88,6 +93,10 @@ class VariationsSeedStore {
// Cached serial number from the most recently fetched variations seed.
std::string variations_serial_number_;
+ // Keeps track of an invalid signature.
+ bool is_invalid_signature_;
+ std::string invalid_signature_;
+
DISALLOW_COPY_AND_ASSIGN(VariationsSeedStore);
};

Powered by Google App Engine
This is Rietveld 408576698