Added incident report for variations seed signature mismatch.

chrome/browser/metrics/variations/variations_seed_store_unittest.cc

Index: chrome/browser/metrics/variations/variations_seed_store_unittest.cc
diff --git a/chrome/browser/metrics/variations/variations_seed_store_unittest.cc b/chrome/browser/metrics/variations/variations_seed_store_unittest.cc
index 6f42c807bf3360a0ef55cdc61ad66638707468b4..407723e525993b70f0c89d0bf310921a449b94c6 100644
--- a/chrome/browser/metrics/variations/variations_seed_store_unittest.cc
+++ b/chrome/browser/metrics/variations/variations_seed_store_unittest.cc
@@ -121,6 +121,44 @@ TEST(VariationsSeedStoreTest, LoadSeed) {
   EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedDate));
   EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedSignature));
 
+  // The below seed and signature pair were generated using the server's

[grt (UTC plus 2), 2014/10/14 01:28:30]

how about moving this new test into its own "GetInvalidSignature" test function?
fine-grained tests make it easier to diagnose failures. this also allows you to
use |seed_store| for the name of the store under test since it won't collide
with the TestVariationsSeedStore used throughout this function.

[Georges Khalil, 2014/10/14 13:51:09]

Done.

+  // private key.
+  const std::string base64_seed_data =
+      "CigxZDI5NDY0ZmIzZDc4ZmYxNTU2ZTViNTUxYzY0NDdjYmM3NGU1ZmQwEr0BCh9VTUEtVW5p"
+      "Zm9ybWl0eS1UcmlhbC0xMC1QZXJjZW50GICckqUFOAFCB2RlZmF1bHRKCwoHZGVmYXVsdBAB"
+      "SgwKCGdyb3VwXzAxEAFKDAoIZ3JvdXBfMDIQAUoMCghncm91cF8wMxABSgwKCGdyb3VwXzA0"
+      "EAFKDAoIZ3JvdXBfMDUQAUoMCghncm91cF8wNhABSgwKCGdyb3VwXzA3EAFKDAoIZ3JvdXBf"
+      "MDgQAUoMCghncm91cF8wORAB";
+  const std::string base64_seed_signature =
+      "MEQCIDD1IVxjzWYncun+9IGzqYjZvqxxujQEayJULTlbTGA/AiAr0oVmEgVUQZBYq5VLOSvy"
+      "96JkMYgzTkHPwbv7K/CmgA==";
+  const std::string base64_seed_signature_invalid =
+      "AEQCIDD1IVxjzWYncun+9IGzqYjZvqxxujQEayJULTlbTGA/AiAr0oVmEgVUQZBYq5VLOSvy"
+      "96JkMYgzTkHPwbv7K/CmgA==";
+
+  // Set seed and valid signature in prefs.
+  prefs.SetString(prefs::kVariationsSeed, base64_seed_data);
+  prefs.SetString(prefs::kVariationsSeedSignature, base64_seed_signature);
+
+  // We need a real VariationsSeedStore to test invalid signatures.
+  VariationsSeedStore seed_store_reel(&prefs);
+  seed_store_reel.LoadSeed(&loaded_seed);
+  std::string invalid_signature;
+  // Valid signature, so we should get an empty string.

[grt (UTC plus 2), 2014/10/14 01:28:30]

update comment

[Georges Khalil, 2014/10/14 13:51:09]

Done.

+  EXPECT_EQ(false, seed_store_reel.GetInvalidSignature(&invalid_signature));

[grt (UTC plus 2), 2014/10/14 01:28:30]

EXPECT_FALSE

[Georges Khalil, 2014/10/14 13:51:09]

Done.

+
+  prefs.SetString(prefs::kVariationsSeedSignature,
+                  base64_seed_signature_invalid);
+  seed_store_reel.LoadSeed(&loaded_seed);
+  // Invalid signature, so we should get the signature itself.
+  EXPECT_EQ(true, seed_store_reel.GetInvalidSignature(&invalid_signature));

[grt (UTC plus 2), 2014/10/14 01:28:30]

EXPECT_FALSE

[Georges Khalil, 2014/10/14 13:51:09]

Done.

+  EXPECT_EQ(invalid_signature, base64_seed_signature_invalid);
+
+  prefs.SetString(prefs::kVariationsSeedSignature, std::string());
+  seed_store_reel.LoadSeed(&loaded_seed);
+  // Empty signature, not considered invalid
+  EXPECT_EQ(false, seed_store_reel.GetInvalidSignature(&invalid_signature));

[grt (UTC plus 2), 2014/10/14 01:28:30]

EXPECT_TRUE

[Georges Khalil, 2014/10/14 13:51:09]

Done.

+
   // Check that having no seed in prefs results in a return value of false.
   prefs.ClearPref(prefs::kVariationsSeed);
   EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed));