Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/browser/metrics/variations/variations_service.cc

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor styling fixes. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.cc
diff --git a/chrome/browser/metrics/variations/variations_service.cc b/chrome/browser/metrics/variations/variations_service.cc
index 8a56747038c32a04bbc09bcb76f8f3c54bdffba5..89abc3702c628af006e2be436653e46966614890 100644
--- a/chrome/browser/metrics/variations/variations_service.cc
+++ b/chrome/browser/metrics/variations/variations_service.cc
@@ -607,4 +607,18 @@ void VariationsService::RecordLastFetchTime() {
}
}
+void VariationsService::OnDelayedSendIncidentReport(
grt (UTC plus 2) 2014/10/10 17:45:42 rather than embed a dependency on safe_browsing he
Georges Khalil 2014/10/10 20:19:31 Agreed, modified the code to reflect this change.
+ const safe_browsing::AddIncidentCallback& callback) {
+ if (!seed_store_.GetBadSignature().empty()) {
+ scoped_ptr<safe_browsing::ClientIncidentReport_IncidentData> incident_data(
+ new safe_browsing::ClientIncidentReport_IncidentData());
+ safe_browsing::
+ ClientIncidentReport_IncidentData_FinchConfigSignatureIncident*
+ finch_config_signature =
+ incident_data->mutable_finch_config_signature();
+ finch_config_signature->set_signature_hash(seed_store_.GetBadSignature());
+ callback.Run(incident_data.Pass());
+ }
+}
+
} // namespace chrome_variations

Powered by Google App Engine
This is Rietveld 408576698