Added incident report for variations seed signature mismatch.

chrome/browser/metrics/variations/variations_seed_store.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/variations/variations_seed_store.h"
 
 #include "base/base64.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
+#include "chrome/browser/browser_process.h"

[grt (UTC plus 2), 2014/10/10 17:45:42]

remove these

[Georges Khalil, 2014/10/10 20:19:31]

Done.

+#include "chrome/browser/safe_browsing/incident_reporting/add_incident_callback.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/common/pref_names.h"
+#include "chrome/common/safe_browsing/csd.pb.h"
 #include "components/variations/proto/variations_seed.pb.h"
 #include "crypto/signature_verifier.h"
 
 namespace chrome_variations {
 
 namespace {
 
 // Signature verification is disabled on mobile platforms for now, since it
 // adds about ~15ms to the startup time on mobile (vs. a couple ms on desktop).
 bool SignatureVerificationEnabled() {
@@ skipping 89 matching lines @@
 }  // namespace
 
 VariationsSeedStore::VariationsSeedStore(PrefService* local_state)
     : local_state_(local_state) {
 }
 
 VariationsSeedStore::~VariationsSeedStore() {
 }
 
 bool VariationsSeedStore::LoadSeed(variations::VariationsSeed* seed) {
+  bad_signature_ = std::string();

[grt (UTC plus 2), 2014/10/10 17:45:42]

  bad_signature_.clear();

[Georges Khalil, 2014/10/10 20:19:31]

Done.

   const std::string base64_seed_data =
       local_state_->GetString(prefs::kVariationsSeed);
   if (base64_seed_data.empty()) {
     RecordVariationSeedEmptyHistogram(VARIATIONS_SEED_EMPTY);
     return false;
   }
 
   // If the decode process fails, assume the pref value is corrupt and clear it.
   std::string seed_data;
   if (!base::Base64Decode(base64_seed_data, &seed_data) ||
@@ skipping 10 matching lines @@
   const VerifySignatureResult result =
       VerifySeedSignature(seed_data, base64_seed_signature);
   if (result != VARIATIONS_SEED_SIGNATURE_ENUM_SIZE) {
     UMA_HISTOGRAM_ENUMERATION("Variations.LoadSeedSignature", result,
                               VARIATIONS_SEED_SIGNATURE_ENUM_SIZE);
     if (result != VARIATIONS_SEED_SIGNATURE_VALID) {
       VLOG(1) << "Variations seed signature in local pref missing or invalid "
               << "with result: " << result << ". Clearing the pref.";
       ClearPrefs();
       RecordVariationSeedEmptyHistogram(VARIATIONS_SEED_INVALID_SIGNATURE);
+      // Record the bad signature, to be used later for sending an incident

[grt (UTC plus 2), 2014/10/10 17:45:42]

same comment about documenting the current consumer.

[Georges Khalil, 2014/10/10 20:19:31]

Done.

+      // report.
+      bad_signature_ = base64_seed_signature;
       return false;
     }
   }
 
   variations_serial_number_ = seed->serial_number();
   RecordVariationSeedEmptyHistogram(VARIATIONS_SEED_NOT_EMPTY);
   return true;
 }
 
 bool VariationsSeedStore::StoreSeedData(
@@ skipping 103 matching lines @@
   }
 
   verifier.VerifyUpdate(reinterpret_cast<const uint8*>(seed_bytes.data()),
                         seed_bytes.size());
   if (verifier.VerifyFinal())
     return VARIATIONS_SEED_SIGNATURE_VALID;
   return VARIATIONS_SEED_SIGNATURE_INVALID_SEED;
 }
 
 }  // namespace chrome_variations