Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: media/formats/mp2t/es_parser_adts_unittest.cc

Issue 646673002: Skip audio frames with unknown timestamp in MPEG2TS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/skip/skipping/ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp2t/es_parser_adts.cc ('k') | media/formats/mp2t/es_parser_mpeg1audio.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp2t/es_parser_adts_unittest.cc
diff --git a/media/formats/mp2t/es_parser_adts_unittest.cc b/media/formats/mp2t/es_parser_adts_unittest.cc
index a65635a53a6356b56f1d3b1654522988fcc12f2e..d1952f30a8850cf9638a5ec9c5d32f032ee4fc82 100644
--- a/media/formats/mp2t/es_parser_adts_unittest.cc
+++ b/media/formats/mp2t/es_parser_adts_unittest.cc
@@ -47,7 +47,11 @@ bool EsParserAdtsTest::Process(
TEST_F(EsParserAdtsTest, NoInitialPts) {
LoadStream("bear.adts");
std::vector<Packet> pes_packets = GenerateFixedSizePesPacket(512);
- EXPECT_FALSE(Process(pes_packets, false));
+ // Process should succeed even without timing info, we should just skip the
+ // audio frames without timing info, but still should be able to parse and
+ // play the stream after that.
+ EXPECT_TRUE(Process(pes_packets, false));
+ EXPECT_EQ(1u, config_count_);
EXPECT_EQ(0u, buffer_count_);
}
« no previous file with comments | « media/formats/mp2t/es_parser_adts.cc ('k') | media/formats/mp2t/es_parser_mpeg1audio.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698