Skip audio frames with unknown timestamp in MPEG2TS

media/formats/mp2t/es_parser_adts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/mp2t/es_parser_adts.h"
 
 #include <list>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 122 matching lines @@
     if (!UpdateAudioConfiguration(adts_frame.data))
       return false;
 
     // Get the PTS & the duration of this access unit.
     TimingDesc current_timing_desc =
         GetTimingDescriptor(adts_frame.queue_offset);
     if (current_timing_desc.pts != kNoTimestamp())
       audio_timestamp_helper_->SetBaseTimestamp(current_timing_desc.pts);
 
     if (audio_timestamp_helper_->base_timestamp() == kNoTimestamp()) {
-      DVLOG(1) << "Audio frame with unknown timestamp";
-      return false;
+      DVLOG(1) << "Skipped audio frame with unknown timestamp";

[damienv1, 2014/10/09 18:29:09]

nit: would prefer the present. "Skip audio frame...

[servolk, 2014/10/09 18:53:04]

Done.

+      SkipAdtsFrame(adts_frame);

[damienv1, 2014/10/09 18:29:09]

Could you update the unit test as well ?

[servolk, 2014/10/09 18:53:04]

Done.

+      continue;

[damienv1, 2014/10/09 18:29:09]

To be consistent, you should do the same for the MPEG1 audio ES parser.
At some point, we might want to have an EsAdapterAudio.

[servolk, 2014/10/09 18:53:03]

Done.

     }
     base::TimeDelta current_pts = audio_timestamp_helper_->GetTimestamp();
     base::TimeDelta frame_duration =
         audio_timestamp_helper_->GetFrameDuration(kSamplesPerAACFrame);
 
     // Emit an audio frame.
     bool is_key_frame = true;
 
     // TODO(wolenetz/acolwell): Validate and use a common cross-parser TrackId
     // type and allow multiple audio tracks. See https://crbug.com/341581.
@@ skipping 96 matching lines @@
     // Audio config notification.
     last_audio_decoder_config_ = audio_decoder_config;
     new_audio_config_cb_.Run(audio_decoder_config);
   }
 
   return true;
 }
 
 }  // namespace mp2t
 }  // namespace media