Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 646653005: Delete unused method for getting push client. (Closed)

Created:
6 years, 1 month ago by Michael van Ouwerkerk
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Delete unused method for getting push client. Depends on https://crrev.com/687933002/ BUG=304341, 350378 Committed: https://crrev.com/382c20799b17a3f21387d1b93d457df6eefaca0c Cr-Commit-Position: refs/heads/master@{#304016}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/renderer/render_view_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
6 years, 1 month ago (2014-10-29 10:57:45 UTC) #2
Peter Beverloo
lgtm (but don't land this until the ASSERT in the other patch goes away).
6 years, 1 month ago (2014-10-29 11:26:11 UTC) #3
Michael van Ouwerkerk
Mike, could you take a look as owner please? Thanks!
6 years, 1 month ago (2014-11-11 18:14:25 UTC) #5
Mike West
lgtm.
6 years, 1 month ago (2014-11-11 18:15:21 UTC) #6
Michael van Ouwerkerk
Sorry Mike, I thought you were a content owner already and the tool suggested you ...
6 years, 1 month ago (2014-11-11 18:16:01 UTC) #8
Mike West
On 2014/11/11 18:16:01, Michael van Ouwerkerk wrote: > Sorry Mike, I thought you were a ...
6 years, 1 month ago (2014-11-11 18:24:25 UTC) #9
Avi (use Gerrit)
lgtm yay!
6 years, 1 month ago (2014-11-11 18:55:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646653005/60001
6 years, 1 month ago (2014-11-13 10:57:21 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-13 11:46:39 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 11:47:18 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/382c20799b17a3f21387d1b93d457df6eefaca0c
Cr-Commit-Position: refs/heads/master@{#304016}

Powered by Google App Engine
This is Rietveld 408576698