Non-SFI Mode: Build libevent with PNaCl toolchain for nacl_helper_nonsfi.

third_party/libevent/libevent_nacl.gyp

Index: third_party/libevent/libevent_nacl.gyp
diff --git a/third_party/libevent/libevent_nacl.gyp b/third_party/libevent/libevent_nacl.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..a1be41fa0a2d2cdda136a70c64193c65b9ffebb1
--- /dev/null
+++ b/third_party/libevent/libevent_nacl.gyp
@@ -0,0 +1,50 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+

[Mark Seaborn, 2014/10/13 16:02:00]

Can you name this file "libevent_nacl_nonsfi.gyp"?  Otherwise readers might
think we're building this to run as user code under SFI NaCl, when we're really
building this to run directly under Linux.

[hidehiko, 2014/10/14 09:07:12]

Done.
FYI: Though, I'm planning to add nonsfi build rule to exiting _nacl.gyp files
for other libraries, such as base_nacl.gyp or ipc_nacl.gyp etc, as the diff is
very small. If you have any concerns about it, please let me know in advance.

[Mark Seaborn, 2014/10/14 15:48:00]

That's fine.  I just don't want readers to misunderstand what target we're
building libevent for.

+{
+  'includes': [
+    '../../build/common_untrusted.gypi',
+  ],
+  'conditions': [
+    ['disable_nacl==0', {
+      'targets': [
+        {
+          'target_name': 'event_nonsfi_nacl',

[Mark Seaborn, 2014/10/13 16:02:01]

Nit: "nonsfi" is used more often as a suffix than a prefix in the code, so could
you name this "event_nacl_nonsfi"?

$ git grep -i 'nacl.*nonsfi' components/nacl ppapi/ | wc -l
230
$ git grep -i 'nonsfi.*nacl' components/nacl ppapi/ | wc -l
68

[hidehiko, 2014/10/14 09:07:12]

Hmm, the former pattern matches to namespace or include directive, such as
nacl::nonsfi::SomeFunction or #include "components/nacl/loader/nonsfi/...",
while the latter matches some constants, like nacl::nonsfi::kNaClSomething.
And, as far as I looked at, there are few good referecnes in both patterns?

Anyway, I have no strong opinion here, so I changed to nonsfi suffix name.
I'll use the same name convention in following CLs.

+          'type': 'none',
+          'sources': [
+            'buffer.c',
+            'evbuffer.c',
+            'event.c',
+            'evutil.c',
+            'log.c',
+            'poll.c',
+            'signal.c',
+            'strlcpy.c',
+            'nacl/config.h',
+            'nacl/event-config.h',
+          ],
+          'defines': [
+            'HAVE_CONFIG_H',
+          ],
+          'variables': {
+            'include_dirs': [
+              'nacl',

[Mark Seaborn, 2014/10/13 16:02:01]

Also "nacl_nonsfi" for this directory?

[hidehiko, 2014/10/14 09:07:12]

Done.

+              '<(DEPTH)/native_client/src/public/linux_syscalls/',

[Mark Seaborn, 2014/10/13 16:02:00]

Nit: Trailing "/" not needed

[hidehiko, 2014/10/14 09:07:12]

Done.

+            ],
+            'nacl_untrusted_build': 1,
+            'nlib_target': 'libevent_nonsfi_nacl.a',
+            'build_glibc': 0,
+            'build_newlib': 0,
+            'build_irt': 0,
+            'build_pnacl_newlib': 0,
+            'build_nonsfi_helper': 1,
+          },
+          'dependencies': [
+            '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
+          ],
+        },
+      ],
+    }],
+  ],
+}