third_party/libevent/README.chromium - Issue 646643002: Non-SFI Mode: Build libevent with PNaCl toolchain for nacl_helper_nonsfi.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libevent/README.chromium

Issue 646643002: Non-SFI Mode: Build libevent with PNaCl toolchain for nacl_helper_nonsfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newlib5

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: libevent	1 Name: libevent

2 URL: http://www.monkey.org/~provos/libevent/	2 URL: http://www.monkey.org/~provos/libevent/

3 Version: 1.4.13	3 Version: 1.4.13

4 License: BSD	4 License: BSD

5 Security Critical: yes	5 Security Critical: yes

6	6

7 Local Modifications:	7 Local Modifications:

8 Rather than use libevent's own build system, we just build a Chrome	8 Rather than use libevent's own build system, we just build a Chrome

9 static library using GYP.	9 static library using GYP.

10	10

11 1) Run configure and "make event-config.h" on Linux, FreeBSD, Solaris,	11 1) Run configure and "make event-config.h" on Linux, FreeBSD, Solaris,

12 and Mac and copy config.h and event-config.h to linux/, freebsd/,	12 and Mac and copy config.h and event-config.h to linux/, freebsd/,

13 solaris/, and mac/ respectively.	13 solaris/, and mac/ respectively.

14 2) Add libevent.gyp.	14 2) Add libevent.gyp.

15 3) chromium.patch is applied to allow libevent to be used without	15 3) chromium.patch is applied to allow libevent to be used without

16 being installed and to fix a race condition.	16 being installed and to fix a race condition.

17 4) The directories WIN32-Code and WIN32-Prj are not included.	17 4) The directories WIN32-Code and WIN32-Prj are not included.

18 5) Apply r87338.	18 5) Apply r87338.

19 6) The configs for android were copied from Linux's which were very close to	19 6) The configs for android were copied from Linux's which were very close to

20 android one with the exception of HAVE_FD_MASK and HAVE_STRLCPY.	20 android one with the exception of HAVE_FD_MASK and HAVE_STRLCPY.

	21 7) Add files to support building with PNaCl toolchain. Added libevent_nacl.gyp
	Mark Seaborn 2014/10/13 16:02:00 Nit: "the PNaCl toolchain" Nit: "the PNaCl toolchain" hidehiko 2014/10/14 09:07:12 Done. Show quoted text On 2014/10/13 16:02:00, Mark Seaborn wrote: > Nit: "the PNaCl toolchain" Done.
	22 for build rule. nacl/config.h and nacl/event-config.h are derived from

	23 linux/ counterparts.

OLD	NEW

« components/nacl_nonsfi.gyp ('K') | « components/nacl_nonsfi.gyp ('k') | third_party/libevent/event-config.h » ('j') | third_party/libevent/libevent_nacl.gyp » ('J')