Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 646623003: Don't scale fixed container adjustment in pinch virtual viewport. (Closed)

Created:
6 years, 2 months ago by bokan
Modified:
6 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, Tima Vaisburd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't scale fixed container adjustment in pinch virtual viewport. In the current method of pinch-zoom, position: fixed elements stick to the visual viewport (i.e. the screen). This means when the user pinch zooms in, the viewport gets smaller so the fixed layers attached to the right and bottom need an adjustment to keep them fixed to the screen. In the new virtual viewport mode, the fixed elements stick to the layout viewport, which doesn't change under scale so we no longer need to scale this adjustment. Additionally, the adjustment that previously came from pinch zooming is not needed at all. BUG=420277 Committed: https://crrev.com/8273d966fa2217069d9d73fd58591a644be71843 Cr-Commit-Position: refs/heads/master@{#300625}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -31 lines) Patch
M cc/layers/layer_impl.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 4 chunks +43 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bokan
PTAL, I'll add a test and land this after the top controls patches land, since ...
6 years, 2 months ago (2014-10-09 18:56:38 UTC) #4
aelias_OOO_until_Jul13
Looks good, nice that this is getting simpler. Description nit: we're still performing an adjustment ...
6 years, 2 months ago (2014-10-09 19:07:04 UTC) #5
bokan
Fixed description + added test, ptal.
6 years, 2 months ago (2014-10-20 15:06:18 UTC) #6
aelias_OOO_until_Jul13
lgtm
6 years, 2 months ago (2014-10-21 22:03:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646623003/100001
6 years, 2 months ago (2014-10-22 00:27:25 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:100001)
6 years, 2 months ago (2014-10-22 02:40:54 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:05:38 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8273d966fa2217069d9d73fd58591a644be71843
Cr-Commit-Position: refs/heads/master@{#300625}

Powered by Google App Engine
This is Rietveld 408576698