Oilpan: Add more trace events to platform/heap/

Oilpan: Add more trace events to platform/heap/

I want to keep track of time spent in the methods.

BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183529

[haraken, 2014-10-10 07:17:09]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[haraken, 2014-10-10 07:17:10]

PTAL

[haraken, 2014-10-10 07:17:37]

haraken@chromium.org changed reviewers:
+ keishi@chromium.org

[haraken, 2014-10-10 07:17:37]

keishi@: PTAL

[sof, 2014-10-10 07:21:19]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2014-10-10 07:21:20]

lgtm

https://codereview.chromium.org/646553005/diff/1/Source/platform/heap/Handle.h
File Source/platform/heap/Handle.h (right):

https://codereview.chromium.org/646553005/diff/1/Source/platform/heap/Handle....
Source/platform/heap/Handle.h:289: TRACE_EVENT0("blink_gc",
"WrapperPersistentRegion::trace");
TRACE_EVENT0() will always be in scope?

[haraken, 2014-10-10 07:27:43]

https://codereview.chromium.org/646553005/diff/1/Source/platform/heap/Handle.h
File Source/platform/heap/Handle.h (right):

https://codereview.chromium.org/646553005/diff/1/Source/platform/heap/Handle....
Source/platform/heap/Handle.h:289: TRACE_EVENT0("blink_gc",
"WrapperPersistentRegion::trace");
On 2014/10/10 07:21:19, sof wrote:
> TRACE_EVENT0() will always be in scope?

Not always. If the TRACE_EVENT0 measures the time spent in one method, we don't
add a scope for the TRACE_EVENT0.

[haraken, 2014-10-10 07:27:45]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-10-10 07:28:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646553005/1

[commit-bot: I haz the power, 2014-10-10 07:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 07:34:46]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/26595)

[sof, 2014-10-10 07:36:54]

On 2014/10/10 07:27:43, haraken wrote:
> https://codereview.chromium.org/646553005/diff/1/Source/platform/heap/Handle.h
> File Source/platform/heap/Handle.h (right):
> 
>
https://codereview.chromium.org/646553005/diff/1/Source/platform/heap/Handle....
> Source/platform/heap/Handle.h:289: TRACE_EVENT0("blink_gc",
> "WrapperPersistentRegion::trace");
> On 2014/10/10 07:21:19, sof wrote:
> > TRACE_EVENT0() will always be in scope?
> 
> Not always. If the TRACE_EVENT0 measures the time spent in one method, we
don't
> add a scope for the TRACE_EVENT0.

Ah, my definition of "scope" was of the more prosaic kind (is TraceEvent.h
always in scope?) :)

[keishi, 2014-10-10 07:37:13]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-10-10 07:38:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646553005/1

[commit-bot: I haz the power, 2014-10-10 07:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 07:46:06]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/26601)

[haraken, 2014-10-10 09:18:12]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-10-10 09:19:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646553005/220002

[commit-bot: I haz the power, 2014-10-10 11:02:10]

Committed patchset #2 (id:220002) as 183529