Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 646543004: Implement :valid and :invalid pseudoclass for <form> (resubmitting) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reorder matchesValidityPseudoClasses() Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormElement.cpp
diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp
index ae110acc3f4f2d73c57fcce4d1083d39e5bf86f5..880b9adeb8a9de71c2e87bc0b52c31361df87af0 100644
--- a/Source/core/html/HTMLFormElement.cpp
+++ b/Source/core/html/HTMLFormElement.cpp
@@ -109,6 +109,16 @@ void HTMLFormElement::trace(Visitor* visitor)
HTMLElement::trace(visitor);
}
+bool HTMLFormElement::matchesValidityPseudoClasses() const
+{
+ return true;
+}
+
+bool HTMLFormElement::isValidElement()
+{
+ return checkValidity();
+}
+
bool HTMLFormElement::rendererIsNeeded(const RenderStyle& style)
{
if (!m_wasDemoted)
@@ -713,6 +723,14 @@ HTMLFormControlElement* HTMLFormElement::defaultButton() const
return 0;
}
+void HTMLFormElement::setNeedsValidityCheck()
+{
+ // For now unconditionally order style recalculation, which triggers
+ // validity recalculation. In the near future, implement validity cache and
+ // recalculate style only if it changed.
+ setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::createWithExtraData(StyleChangeReason::PseudoClass, StyleChangeExtraData::Invalid));
+}
+
bool HTMLFormElement::checkValidity()
{
return !checkInvalidControlsAndCollectUnhandled(0);
« no previous file with comments | « Source/core/html/HTMLFormElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698