Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 646543004: Implement :valid and :invalid pseudoclass for <form> (resubmitting) (Closed)

Created:
6 years, 2 months ago by Bartek Nowierski
Modified:
6 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, tkent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement :valid and :invalid pseudoclass for <form> (resubmitting) BUG=360466 TEST=added form-pseudo-valid-style.html layout test Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183729

Patch Set 1 #

Patch Set 2 : Decapitalize OVERRIDE and FINAL #

Patch Set 3 : Stop using willValidate for :valid/:invalid pseudo-classes #

Total comments: 2

Patch Set 4 : Reorder matchesValidityPseudoClasses() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -7 lines) Patch
A LayoutTests/fast/forms/form-pseudo-valid-style.html View 1 chunk +80 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/form-pseudo-valid-style-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 2 4 chunks +27 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
keishi
lgtm
6 years, 2 months ago (2014-10-15 02:15:57 UTC) #2
keishi
lgtm https://codereview.chromium.org/646543004/diff/40001/Source/core/dom/Element.h File Source/core/dom/Element.h (right): https://codereview.chromium.org/646543004/diff/40001/Source/core/dom/Element.h#newcode433 Source/core/dom/Element.h:433: virtual bool matchesValidityPseudoClasses() const { return false; } ...
6 years, 2 months ago (2014-10-15 06:37:16 UTC) #3
Bartek Nowierski
https://codereview.chromium.org/646543004/diff/40001/Source/core/dom/Element.h File Source/core/dom/Element.h (right): https://codereview.chromium.org/646543004/diff/40001/Source/core/dom/Element.h#newcode433 Source/core/dom/Element.h:433: virtual bool matchesValidityPseudoClasses() const { return false; } On ...
6 years, 2 months ago (2014-10-15 06:43:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646543004/60001
6 years, 2 months ago (2014-10-15 06:45:29 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 09:01:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 183729

Powered by Google App Engine
This is Rietveld 408576698