Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 646543003: [components] Apply automatic range checks to content enum types across IPC (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
Mike West, blundell
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[components] Apply automatic range checks to content enum types across IPC This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/b82b5f8707ab95d4deaa71bbcd66ce5462dc0ecd Cr-Commit-Position: refs/heads/master@{#298915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/translate/content/common/translate_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/translate/core/common/translate_errors.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-09 14:27:48 UTC) #2
Mike West
On 2014/10/09 14:27:48, anujsharma wrote: > PTAL Messages LGTM. You'll need signoff for the enum ...
6 years, 2 months ago (2014-10-09 14:43:50 UTC) #3
blundell
lgtm
6 years, 2 months ago (2014-10-09 14:46:06 UTC) #4
anujsharma
On 2014/10/09 14:46:06, blundell wrote: > lgtm Thanks mike and blundell for lgtm.
6 years, 2 months ago (2014-10-09 16:21:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646543003/1
6 years, 2 months ago (2014-10-09 16:25:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 17:07:04 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 17:08:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b82b5f8707ab95d4deaa71bbcd66ce5462dc0ecd
Cr-Commit-Position: refs/heads/master@{#298915}

Powered by Google App Engine
This is Rietveld 408576698