build/android/pylib/gtest/test_package_exe.py - Issue 646523002: [Android] Add zip pushing and refine push mode selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_exe.py

Issue 646523002: [Android] Add zip pushing and refine push mode selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix findbugs issues. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/test_package_exe.py

diff --git a/build/android/pylib/gtest/test_package_exe.py b/build/android/pylib/gtest/test_package_exe.py

index 5f82aad7b550af76bf23f753b71578251d5df9b1..b0be35ca8a47a55ed737ccbf7cb54f6a97791687 100644

--- a/build/android/pylib/gtest/test_package_exe.py

+++ b/build/android/pylib/gtest/test_package_exe.py

@@ -105,9 +105,9 @@ class TestPackageExecutable(TestPackage):

TestPackageExecutable._TEST_RUNNER_RET_VAL_FILE))

sh_script_file.flush()

cmd_helper.RunCmd(['chmod', '+x', sh_script_file.name])

- device.PushChangedFiles(

+ device.PushChangedFiles([(

sh_script_file.name,

- constants.TEST_EXECUTABLE_DIR + '/chrome_test_runner.sh')

+ constants.TEST_EXECUTABLE_DIR + '/chrome_test_runner.sh')])

logging.info('Conents of the test runner script: ')

for line in open(sh_script_file.name).readlines():

logging.info(' ' + line.rstrip())

@@ -148,4 +148,4 @@ class TestPackageExecutable(TestPackage):

self.suite_name + '_stripped'))

test_binary = constants.TEST_EXECUTABLE_DIR + '/' + self.suite_name

- device.PushChangedFiles(target_name, test_binary)

+ device.PushChangedFiles([(target_name, test_binary)])

« no previous file with comments | « build/android/pylib/gtest/test_package_apk.py ('k') | build/android/pylib/gtest/test_runner.py » ('j') | no next file with comments »