Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 646483009: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/b7a5a049fe93d6bcfb16ebd4544c16f97404d00b Cr-Commit-Position: refs/heads/master@{#300020}

Patch Set 1 #

Patch Set 2 : Reflow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M mojo/application_manager/application_manager_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/blink_input_events_type_converters.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/external_application_listener_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-16 21:51:52 UTC) #2
viettrungluu
lgtm
6 years, 2 months ago (2014-10-16 23:01:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646483009/20001
6 years, 2 months ago (2014-10-16 23:02:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 00:08:03 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:08:53 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7a5a049fe93d6bcfb16ebd4544c16f97404d00b
Cr-Commit-Position: refs/heads/master@{#300020}

Powered by Google App Engine
This is Rietveld 408576698