[turbofan] Fix typed lowering of typed array loads/stores.

src/compiler/js-typed-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
 #include "src/compiler/graph-inl.h"
 #include "src/compiler/js-builtin-reducer.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/node-aux-data-inl.h"
 #include "src/compiler/node-properties-inl.h"
@@ skipping 523 matching lines @@
   Type* base_type = NodeProperties::GetBounds(base).upper;
   // TODO(mstarzinger): This lowering is not correct if:
   //   a) The typed array or it's buffer is neutered.
   if (base_type->IsConstant() && key_type->Is(Type::Integral32()) &&
       base_type->AsConstant()->Value()->IsJSTypedArray()) {
     // JSLoadProperty(typed-array, int32)
     Handle<JSTypedArray> array =
         Handle<JSTypedArray>::cast(base_type->AsConstant()->Value());
     if (IsExternalArrayElementsKind(array->map()->elements_kind())) {
       ExternalArrayType type = array->type();
-      uint32_t length;
-      CHECK(array->length()->ToUint32(&length));
-      Node* elements = graph()->NewNode(
-          simplified()->LoadField(AccessBuilder::ForJSObjectElements()), base,
-          graph()->start());
-      Node* pointer = graph()->NewNode(
-          simplified()->LoadField(AccessBuilder::ForExternalArrayPointer()),
-          elements, elements);
-      Node* effect = NodeProperties::GetEffectInput(node);
-      Node* control = NodeProperties::GetControlInput(node);
-      Node* load = graph()->NewNode(
-          simplified()->LoadElement(
-              AccessBuilder::ForTypedArrayElement(type, true)),
-          pointer, key, jsgraph()->Uint32Constant(length), effect, control);
-      return ReplaceEagerly(node, load);
+      uint32_t byte_length;
+      if (array->byte_length()->ToUint32(&byte_length)) {
+        Node* elements = graph()->NewNode(
+            simplified()->LoadField(AccessBuilder::ForJSObjectElements()), base,
+            graph()->start());
+        Node* pointer = graph()->NewNode(
+            simplified()->LoadField(AccessBuilder::ForExternalArrayPointer()),
+            elements, elements);
+        Node* length = jsgraph()->Uint32Constant(
+            static_cast<uint32_t>(byte_length / array->element_size()));
+        Node* effect = NodeProperties::GetEffectInput(node);
+        Node* control = NodeProperties::GetControlInput(node);
+        Node* load = graph()->NewNode(
+            simplified()->LoadElement(
+                AccessBuilder::ForTypedArrayElement(type, true)),
+            pointer, key, length, effect, control);
+        return ReplaceEagerly(node, load);
+      }
     }
   }
   return NoChange();
 }
 
 
 Reduction JSTypedLowering::ReduceJSStoreProperty(Node* node) {
   Node* key = NodeProperties::GetValueInput(node, 1);
   Node* base = NodeProperties::GetValueInput(node, 0);
   Node* value = NodeProperties::GetValueInput(node, 2);
   Type* key_type = NodeProperties::GetBounds(key).upper;
   Type* base_type = NodeProperties::GetBounds(base).upper;
   // TODO(mstarzinger): This lowering is not correct if:
   //   a) The typed array or its buffer is neutered.
   if (key_type->Is(Type::Integral32()) && base_type->IsConstant() &&
       base_type->AsConstant()->Value()->IsJSTypedArray()) {
     // JSStoreProperty(typed-array, int32, value)
     Handle<JSTypedArray> array =
         Handle<JSTypedArray>::cast(base_type->AsConstant()->Value());
     if (IsExternalArrayElementsKind(array->map()->elements_kind())) {
       ExternalArrayType type = array->type();
-      uint32_t length;
-      CHECK(array->length()->ToUint32(&length));
-      Node* elements = graph()->NewNode(
-          simplified()->LoadField(AccessBuilder::ForJSObjectElements()), base,
-          graph()->start());
-      Node* pointer = graph()->NewNode(
-          simplified()->LoadField(AccessBuilder::ForExternalArrayPointer()),
-          elements, elements);
-      Node* effect = NodeProperties::GetEffectInput(node);
-      Node* control = NodeProperties::GetControlInput(node);
-      Node* store =
-          graph()->NewNode(simplified()->StoreElement(
-                               AccessBuilder::ForTypedArrayElement(type, true)),
-                           pointer, key, jsgraph()->Uint32Constant(length),
-                           value, effect, control);
-      return ReplaceEagerly(node, store);
+      uint32_t byte_length;
+      if (array->byte_length()->ToUint32(&byte_length)) {
+        Node* elements = graph()->NewNode(
+            simplified()->LoadField(AccessBuilder::ForJSObjectElements()), base,
+            graph()->start());
+        Node* pointer = graph()->NewNode(
+            simplified()->LoadField(AccessBuilder::ForExternalArrayPointer()),
+            elements, elements);
+        Node* length = jsgraph()->Uint32Constant(
+            static_cast<uint32_t>(byte_length / array->element_size()));
+        Node* effect = NodeProperties::GetEffectInput(node);
+        Node* control = NodeProperties::GetControlInput(node);
+        Node* store = graph()->NewNode(
+            simplified()->StoreElement(
+                AccessBuilder::ForTypedArrayElement(type, true)),
+            pointer, key, length, value, effect, control);
+        return ReplaceEagerly(node, store);
+      }
     }
   }
   return NoChange();
 }
 
 
 static Reduction ReplaceWithReduction(Node* node, Reduction reduction) {
   if (reduction.Changed()) {
     NodeProperties::ReplaceWithValue(node, reduction.replacement());
     return reduction;
@@ skipping 84 matching lines @@
       return JSBuiltinReducer(jsgraph()).Reduce(node);
     default:
       break;
   }
   return NoChange();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8