[turbofan] remove some of the dependency of Instruction on Schedule

[turbofan] remove some of the dependency of Instruction on Schedule

R=bmeurer@chromium.org

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=24584

[dcarney, 2014-10-13 13:17:51]

dcarney@chromium.org changed reviewers:
+ bmeurer@chromium.org

[dcarney, 2014-10-13 13:18:27]

Patchset #1 (id:1) has been deleted

[dcarney, 2014-10-13 13:18:33]

Patchset #1 (id:60001) has been deleted

[dcarney, 2014-10-13 13:18:38]

Patchset #1 (id:100001) has been deleted

[dcarney, 2014-10-13 13:18:43]

Patchset #1 (id:170001) has been deleted

[Benedikt Meurer, 2014-10-14 03:44:13]

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
src/compiler/instruction-selector.cc:386: // TODO(bmeurer): We should not mutate
the schedule.
You can remove this TODO.

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
src/compiler/instruction.h:923: const BlockData& GetBlockData(BasicBlock* block)
const {
Can we avoid adding this wrapper function?

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
src/compiler/instruction.h:923: const BlockData& GetBlockData(BasicBlock* block)
const {
Can we avoid adding this wrapper function?

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
src/compiler/instruction.h:929: BlockData& GetBlockData(BasicBlock* block) {
Can we avoid adding this wrapper function?

https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h
File src/compiler/schedule.h (right):

https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h...
src/compiler/schedule.h:53: class RpoNumber {
Mark as FINAL.

[dcarney, 2014-10-14 08:14:37]

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
src/compiler/instruction-selector.cc:386: // TODO(bmeurer): We should not mutate
the schedule.
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
> You can remove this TODO.

Done.

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
src/compiler/instruction.h:923: const BlockData& GetBlockData(BasicBlock* block)
const {
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
> Can we avoid adding this wrapper function?

Done.

https://codereview.chromium.org/646393002/diff/200001/src/compiler/instructio...
src/compiler/instruction.h:929: BlockData& GetBlockData(BasicBlock* block) {
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
> Can we avoid adding this wrapper function?

Done.

https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h
File src/compiler/schedule.h (right):

https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h...
src/compiler/schedule.h:53: class RpoNumber {
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
> Mark as FINAL.

Done.

[Benedikt Meurer, 2014-10-14 08:43:38]

LGTM

[dcarney, 2014-10-14 08:51:40]

Committed patchset #2 (id:280001) manually as 24584 (presubmit successful).