Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 646373002: Run benchmarks tests with --turbo-asm flag. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/benchmarks/testcfg.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-13 09:11:17 UTC) #1
Michael Achenbach
https://codereview.chromium.org/646373002/diff/1/test/benchmarks/testcfg.py File test/benchmarks/testcfg.py (right): https://codereview.chromium.org/646373002/diff/1/test/benchmarks/testcfg.py#newcode189 test/benchmarks/testcfg.py:189: return [[], ["--turbo-asm --turbo-filter=*"]] + ,
6 years, 2 months ago (2014-10-13 09:25:59 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/646373002/diff/1/test/benchmarks/testcfg.py File test/benchmarks/testcfg.py (right): https://codereview.chromium.org/646373002/diff/1/test/benchmarks/testcfg.py#newcode189 test/benchmarks/testcfg.py:189: return [[], ["--turbo-asm --turbo-filter=*"]] On 2014/10/13 09:25:59, Michael Achenbach ...
6 years, 2 months ago (2014-10-13 09:26:41 UTC) #3
Michael Achenbach
lgtm
6 years, 2 months ago (2014-10-13 09:30:07 UTC) #4
Benedikt Meurer
6 years, 2 months ago (2014-10-13 09:30:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) manually as 24549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698