Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: net/base/escape.h

Issue 646333002: Update EscapeExternalHandlerValue to keep '#', '[', and ']' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/escape.cc » ('j') | net/base/escape.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/escape.h
diff --git a/net/base/escape.h b/net/base/escape.h
index 1915d24418883a2186ffc329733a93bc43938085..eee70d7524d04ee6ec09b0c134bb7a90074b2d50 100644
--- a/net/base/escape.h
+++ b/net/base/escape.h
@@ -42,8 +42,8 @@ NET_EXPORT std::string EscapeNonASCII(const std::string& input);
// Escapes characters in text suitable for use as an external protocol handler
// command.
-// We %XX everything except alphanumerics and %-_.!~*'() and the restricted
-// chracters (;/?:@&=+$,).
+// We %XX everything except alphanumerics and %-_.!~*'(), the restricted
+// chracters (;/?:@&=+$,#[]), and ones which are already escaped.
asanka 2014/10/23 07:20:04 Since % is already mentioned in the exclusion list
Jaekyun Seok (inactive) 2014/10/23 12:43:19 Sorry, I should have removed '%' because here we a
NET_EXPORT std::string EscapeExternalHandlerValue(const std::string& text);
// Appends the given character to the output string, escaping the character if
« no previous file with comments | « no previous file | net/base/escape.cc » ('j') | net/base/escape.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698