chrome/browser/android/url_sanitize_utils.h - Issue 646333002: Update EscapeExternalHandlerValue to keep '#', '[', and ']'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/url_sanitize_utils.h

Issue 646333002: Update EscapeExternalHandlerValue to keep '#', '[', and ']' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sanitize fragment and path Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_ANDROID_URL_SANITIZE_UTILS_H_

	6 #define CHROME_BROWSER_ANDROID_URL_SANITIZE_UTILS_H_

	7

	8 #include "url/gurl.h"

	9

	10 namespace chrome {

	11 namespace android {

	12

	13 // Sanitizes a query part of \|url\|.

	14 // This function escapes characters in a query part of \|url\| suitable for use as

	15 // a URI query part. See RFC 2396 for the list of reserved characters.
	asanka 2014/10/14 16:46:03 * Mention that this function escapes all but the s * Mention that this function escapes all but the strict set of allowed characters in each component of the URL. * Note why this is required. * Note differences between what GURL already does. Jaekyun Seok (inactive) 2014/10/15 08:02:25 Done. Show quoted text On 2014/10/14 16:46:03, asanka wrote: > * Mention that this function escapes all but the strict set of allowed > characters in each component of the URL. > > * Note why this is required. > > * Note differences between what GURL already does. Done.
	16 GURL SanitizeUrl(const GURL& url);

	17

	18 } // namespace android

	19 } // namespace chrome

	20

	21 #endif // CHROME_BROWSER_ANDROID_URL_SANITIZE_UTILS_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/android/url_sanitize_utils.cc » ('j') | chrome/browser/android/url_sanitize_utils.cc » ('J')