Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 646303004: aw: Ensure invalidation when pipeline is stalled (Closed)

Created:
6 years, 2 months ago by boliu
Modified:
6 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

aw: Ensure invalidation when pipeline is stalled * If CommitFrame is skipped to to stall, ensure we invalidate. * Make sure force_invalidate does not get cancelled by a pending fallback tick. * Allow hardware initialization even when visible rect is empty, so fallback tick is always in the right mode. * Fix visible rect empty checks. BUG=425372 Review URL: https://codereview.chromium.org/654403006 TBR=boliu@chromium.org Cr-Commit-Position: refs/heads/master@{#300566} (cherry picked from commit 6b96a049428fceb4af34a5ea92b106ae208ea75b) Conflicts: android_webview/browser/browser_view_renderer.h android_webview/native/aw_contents.h Committed: https://chromium.googlesource.com/chromium/src/+/edd88dfbf6331fab8cae4151a5f62455f551d2e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -17 lines) Patch
M android_webview/browser/browser_view_renderer.h View 3 chunks +4 lines, -1 line 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 8 chunks +34 lines, -16 lines 0 comments Download
M android_webview/browser/browser_view_renderer_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/shared_renderer_state.h View 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
boliu
6 years, 2 months ago (2014-10-22 17:05:39 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edd88dfbf6331fab8cae4151a5f62455f551d2e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698