Issue 6463024: gtk: Show a tooltip for the location icon in the omnibox.

Issue 6463024: gtk: Show a tooltip for the location icon in the omnibox. (Closed)

Created:
9 years, 10 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Finnur, Glen Murphy, Evan Stade

CC:
chromium-reviews

Visibility:
Public.

Description

gtk: Show a tooltip for the location icon in the omnibox. BUG=41073 TEST=launch chrome, hover the location icon, a tooltip with "View site information" should appears. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74426

Patch Set 1 : #

Patch Set 2 : wording #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1	1 chunk	+3 lines, -0 lines	1 comment	Download
	M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I think the tooltip should be "Click to view site information.", but it's probably best ...

9 years, 10 months ago (2011-02-09 21:35:45 UTC) #3

tfarina

http://codereview.chromium.org/6463024/diff/6001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/6463024/diff/6001/chrome/app/generated_resources.grd#newcode4414 chrome/app/generated_resources.grd:4414: Click to view site information Glen is this OK?

9 years, 10 months ago (2011-02-09 23:20:59 UTC) #4

Finnur

LGTM. Do you plan on doing the Mac and Windows work as well? On 2011/02/09 ...

9 years, 10 months ago (2011-02-10 09:57:17 UTC) #5

tfarina

On 2011/02/10 09:57:17, Finnur wrote: > LGTM. Do you plan on doing the Mac and ...

9 years, 10 months ago (2011-02-10 11:52:54 UTC) #6

Evan Stade

you can go ahead and commit, and send an email to Glen to see if ...

9 years, 10 months ago (2011-02-10 19:51:28 UTC) #7

Glen Murphy

9 years, 10 months ago (2011-02-14 17:43:57 UTC) #8

I'd remove the 'click to' and just say "View site information" (none
of our other controls contain interaction instructions).

--
Processing two weeks of email, sorry for brevity and dredging up old threads.


On Thu, Feb 10, 2011 at 11:51 AM,  <estade@chromium.org> wrote:
> you can go ahead and commit, and send an email to Glen to see if he wants to
> tweak the string after the fact
>
> http://codereview.chromium.org/6463024/
>

Expand Messages | Collapse Messages