Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: sky/engine/core/rendering/RenderPart.cpp

Issue 646273006: Get rid of ScrollView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: merge to ToT Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderPart.cpp
diff --git a/sky/engine/core/rendering/RenderPart.cpp b/sky/engine/core/rendering/RenderPart.cpp
index 377c2b104eed83d26ce19858ac4472aa7d49ead1..11e4c8e33d4656e0eeb81ddbfe9a173efeebde74 100644
--- a/sky/engine/core/rendering/RenderPart.cpp
+++ b/sky/engine/core/rendering/RenderPart.cpp
@@ -85,15 +85,6 @@ bool RenderPart::nodeAtPoint(const HitTestRequest& request, HitTestResult& resul
if (isInsideChildFrame)
return true;
-
- if (request.allowsFrameScrollbars()) {
- // ScrollView scrollbars are not the same as RenderLayer scrollbars tested by RenderLayer::hitTestOverflowControls,
- // so we need to test ScrollView scrollbars separately here.
- // FIXME: Consider if this test could be done unconditionally.
- Scrollbar* frameScrollbar = childFrameView->scrollbarAtPoint(newHitTestLocation.roundedPoint());
- if (frameScrollbar)
- result.setScrollbar(frameScrollbar);
- }
}
return RenderWidget::nodeAtPoint(request, result, locationInContainer, accumulatedOffset, action);

Powered by Google App Engine
This is Rietveld 408576698